From ecd64846a83278b0523bfa87aa333e442897a916 Mon Sep 17 00:00:00 2001 From: Yasuyuki Tanaka Date: Thu, 22 Mar 2018 17:38:56 +0000 Subject: [PATCH] shell: add NULL pointer check --- os/services/shell/shell-commands.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/os/services/shell/shell-commands.c b/os/services/shell/shell-commands.c index 5e19a0dc8..c011b780c 100644 --- a/os/services/shell/shell-commands.c +++ b/os/services/shell/shell-commands.c @@ -218,7 +218,10 @@ PT_THREAD(cmd_ping(struct pt *pt, shell_output_func output, char *args)) /* Get argument (remote IPv6) */ SHELL_ARGS_NEXT(args, next_args); - if(uiplib_ipaddrconv(args, &remote_addr) == 0) { + if(args == NULL) { + SHELL_OUTPUT(output, "Destination IPv6 address is not specified\n"); + PT_EXIT(pt); + } else if(uiplib_ipaddrconv(args, &remote_addr) == 0) { SHELL_OUTPUT(output, "Invalid IPv6: %s\n", args); PT_EXIT(pt); }