giomba
/
nes-proj
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

enc28j60: Reuse read/writedata() for read/writedatabyte() 

The read/writedatabyte() functions are just a special case of
read/writedata() with a simpler API, so reuse these instead of
duplicating code.

Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev@gmail.com>
This commit is contained in:
Benoît Thébaudeau 2015-07-14 18:27:06 +02:00
parent 01251e94c6
commit 35544e81ee
1 changed files with 11 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
dev/enc28j60/enc28j60.c
View File

@ -160,16 +160,6 @@ setregbank(uint8_t bank)
} }
/*---------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/
static void static void
writedatabyte(uint8_t byte)
{
enc28j60_arch_spi_select();
/* The Write Buffer Memory (WBM) command is 0 1 1 1 1 0 1 0 */
enc28j60_arch_spi_write(0x7a);
enc28j60_arch_spi_write(byte);
enc28j60_arch_spi_deselect();
}
/*---------------------------------------------------------------------------*/
static void
writedata(uint8_t *data, int datalen) writedata(uint8_t *data, int datalen)
{ {
int i; int i;
@ -182,16 +172,10 @@ writedata(uint8_t *data, int datalen)
enc28j60_arch_spi_deselect(); enc28j60_arch_spi_deselect();
} }
/*---------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/
static uint8_t static void
readdatabyte(void) writedatabyte(uint8_t byte)
{ {
uint8_t r; writedata(&byte, 1);
enc28j60_arch_spi_select();
/* THe Read Buffer Memory (RBM) command is 0 0 1 1 1 0 1 0 */
enc28j60_arch_spi_write(0x3a);
r = enc28j60_arch_spi_read();
enc28j60_arch_spi_deselect();
return r;
} }
/*---------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/
static int static int
@ -208,6 +192,14 @@ readdata(uint8_t *buf, int len)
return i; return i;
} }
/*---------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/
static uint8_t
readdatabyte(void)
{
uint8_t r;
readdata(&r, 1);
return r;
}
/*---------------------------------------------------------------------------*/
static void static void
softreset(void) softreset(void)
{ {